this post was submitted on 24 Jan 2024
4 points (100.0% liked)

Programming Horror

2328 readers
1 users here now

Welcome to Programming Horror!

This is a place to share strange or terrible code you come across.

For more general memes about programming there's also Programmer Humor.

Looking for mods. If youre interested in moderating the community feel free to dm @Ategon@programming.dev

Rules

Credits

founded 2 years ago
MODERATORS
 

I was looking through various RCON tools and found this. Someone does not like commit messages.

top 9 comments
sorted by: hot top controversial new old
[–] drsensor@programming.dev 1 points 2 years ago (2 children)

At least it's better than me messing up with the commit date :v https://github.com/DrSensor/rescript.nix/commits/trunk/

[–] recursive_recursion@programming.dev 1 points 2 years ago* (last edited 2 years ago)

what in the

very odd behaviour to say the least
that's their personal project or I hope anyways

[–] inspxtr@lemmy.world 0 points 2 years ago (1 children)
[–] kryllic@programming.dev 1 points 2 years ago

Don't commit near a black hole, apparently

[–] Mikina@programming.dev 1 points 2 years ago

I think that there's one important point to consider that may not be immediately obvious, when deciding about commit messages in FOSS project, even if you are not accepting contributions and just want to share your work for others - auditabilty.

7-zip has been receiving critique for this for a long time - not having commit messages makes it way harder to check what the actual changes were. Sure you can't trust commit messages during an audit, but it makes it a lot easier - either you immediately notice that they are lying, or they are correct and will help you with understanding the change, so you can decide for yourself whether it's safe.

Of course, the author is doing a lot of work for free, that he offers to others, so we have no right to blame him for it or demand he changes his approach. I'm grateful for any FOSS project, and demanding from someone directly that he's doing it wrong and should do it some other way (or belittling him for it) isn't OK. However, I'd probably be very careful when encountering a repository like this, and reconsider whether it's worth adopting. Which is absolutely ok and I don't blame the author for it in the slightest - it's his repo and his work - but I also think that auditability may be something the author didn't realize, and assuming his goal was to share his code with others i.e to build a portfolio, may affect his overall adoption rate. But it's also ok if he simply doesn't care about that.

But in general, if you're making a FOSS project, I'd recommend sticking with good commit messages.

[–] wischi@programming.dev 0 points 2 years ago (1 children)

Not really programming horror. Just open source. They did something, are kind enough to make it open, they don't care about commit messages so what?

[–] Sibbo@sopuli.xyz 0 points 2 years ago (1 children)

This. Like if they are working for free for the public good, don't complain if they don't do it thoroughly enough. If someone volunteers to pick up trash from the park, you wouldn't complain if he misses some things or stops before the whole park is clean.

[–] ExtraMedicated@lemmy.world 0 points 2 years ago (1 children)

For me, the thing is, commit messages aren't just for other people. They can be invaluable in case you need to look back for something. I even write them for my personal repos that aren't even on the internet, because it's really just kinda dumb not to.

[–] Sibbo@sopuli.xyz 1 points 2 years ago

Yeah, but that doesn't mean that everyone else has to work as methodical as you do for any project they do. Even if it is more efficient and saves time in the long term.