Programmer Humor

22809 readers

687 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

Keep content in english
No advertisements
Posts must be related to programming or programmer topics

founded 2 years ago

MODERATORS

[email protected]

195

is my PR big enough ? (feddit.dk)

submitted 2 weeks ago by [email protected] to c/[email protected]

39 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 4 points 2 weeks ago (15 children)

Because my company works on archaic infrastructure, should PRs be as small as possible with sub-issues sorted into smaller PRs?

[–] [email protected] 5 points 2 weeks ago (2 children)

I err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it'll get slapped with a LGTM and passed. If I send them 100 lines they'll actually look at it.

[–] [email protected] 2 points 2 weeks ago (1 children)

LGTM= let’s go to the moon?

[–] [email protected] 2 points 2 weeks ago

Looks good to me, are you getting the rocket?

load more comments (12 replies)