Feddit UK

1470 readers

4 users here now

Community for the Feddit UK instance.
A place to log issues, and for the admins to communicate with everyone.

founded 2 years ago

MODERATORS

[email protected]

bsky images don't show on feddit.uk (only) via app (only) (feddit.uk)

submitted 1 week ago by [email protected] to c/[email protected]

17 comments fedilink hide all child comments

I'm asking this here because it looks like a very weird feddit.uk specific issue.

If I post a URL for cdn.bsky.app to an image, it shows up fine on the default web UI.

On the app I use (Connect) it only ever shows up as a link.

"But!", I hear you cry, "surely that's an app problem?"

You'd think so, and I thought so, but it is only happening on feddit.uk. If I switch to a different account on a different instance, they display as expected. It also doesn't matter which instance they were originally posted to, as I've just seen an image from bsky that I posted on feddit.uk, and that has the same problem.

Any ideas? This has been bugging me for weeks.

cross-posted from: https://feddit.uk/post/24365548

This is a bit odd. From my feddit.uk account (this one) I get the above for posts on [email protected].

If I log into the account they were posted with (this is my bot) on lemmings.world they display as expected:

If I log back in as myself on feddit.uk website, the images also display as expected (Connect doesn't seem to want to upload this one, but you'll see it without logging in at feddit.uk/c/[email protected]).

What's different?

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 3 points 6 days ago (3 children)

Hello, Connect dev here but I'll also tag the Thunder dev @[email protected] as far as I know we're the two Flutter based front-ends.

The issue I believe seems to be with how the URI gets parsed for Bluesky. Since the URL path ends with @jpeg?.jpg the uri.path that I get ends up being "/img/feed_fullsize/plain/did:plc:wf7nfy2us3h5gpa7zfettmzl/bafkreidiiq5pzo4dec3o32z4okokwo5vz55ykd5vsm7ltqkxzrfpwnah64@jpeg" instead of the typical some_path/some_image.jpg. So when the code checks if the url is an image it doesn't find a file extension and reports that this is a link and not an image. The simplified form of what I'm doing app-side is

List<String> imageFormats = [
    "jpg",
    ...
];
var uri = Uri.parse(url);
var extension = uri.path.split('.').last;
if (imageFormats.contains(extension)) {
    return true;
}
...

For some instances this is not a problem since they are proxying all image requests which is why it might be happening only on specific instances for you.

I'll roll this fix into the next version, which should be rolling out tonight.

[–] [email protected] 1 points 6 days ago

If you don't mind me asking, but what's the reason you're detecting images like this instead of using the MIME type Lemmy indicates (or hell, the one in the Content-Type header from GET'ting the URL)?

load more comments (2 replies)